Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Client creation and build performance #341

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Improve Client creation and build performance #341

merged 9 commits into from
Dec 3, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Dec 1, 2024 •
edited
Loading

This adds an optional inboxId to build to get rid of the expensive getInboxId.

Operation Previously Now
Get inboxId 0.524s (Not Present)
Create inboxId 0.002s 0.002s
Create ffi client 0.515s 0.493s
Overall Previously Now
Created a client 2.9s 1.97s
Built a client 0.751s 0.384s

@nplasterer nplasterer self-assigned this Dec 1, 2024
@nplasterer nplasterer marked this pull request as ready for review December 3, 2024 18:00
@nplasterer nplasterer requested a review from a team as a code owner December 3, 2024 18:00
@nplasterer nplasterer merged commit 1a2d6a6 into main Dec 3, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/client-performance branch December 3, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codabrink codabrink codabrink approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @codabrink